Method size (MethodSize)¶

Type	Scope	Severity	Activated by default	Minutes to fix	Tags
`Code smell`	`BSL` `OS`	`Major`	`Yes`	`30`	`badpractice`

Parameters¶

Name	Type	Description	Default value
`maxMethodSize`	`Integer`	`Max method line count.`	`200`

Description¶

There are cumbersome methods (procedures and functions) which mskes it impossible to work effectively precisely because of their huge size.
A large method often arises when a developer adds new functionality to a method. “Why should I put the parameter check in a separate method, if I can write it here?”, “Why do I need to create a separate method for the search of maximum element in the array, let’s leave it here. So the code is clearer”, and other misconceptions.

There are two rules for refactoring a large method:

If when writing a method you want to add a comment to the code, you must put this functionality in a separate method
If the method takes more than 50-100 lines of code, you should determine the tasks and subtasks that it performs and try to put the subtasks in a separate method

Sources¶

Snippets¶

Diagnostic ignorance in code¶

// BSLLS:MethodSize-off
// BSLLS:MethodSize-on

Parameter for config¶

"MethodSize": {
    "maxMethodSize": 200
}